[core] Protect a string search from running out of bounds.#21320
Open
hageboeck wants to merge 1 commit intoroot-project:masterfrom
Open
[core] Protect a string search from running out of bounds.#21320hageboeck wants to merge 1 commit intoroot-project:masterfrom
hageboeck wants to merge 1 commit intoroot-project:masterfrom
Conversation
When running gtest-tree-ntuple-ntuple-type-name in address sanitizer,
the check for the "const" qualifier ran out of bounds, because the
cursor in TClassEdit.cxx:1793 was already at the end of the string, and
"next" was one character after its end:
"std::vector<Double32_t[3] > [10 ] "
^
strcmp isn't designed for this case, so this commit adds length checks
before all "strcmp(base+offset, ...)" patterns.
silverweed
approved these changes
Feb 19, 2026
Collaborator
Member
Author
Test Results 22 files 22 suites 3d 6h 36m 25s ⏱️ For more details on these failures, see this check. Results for commit b09b756. ♻️ This comment has been updated with latest results. |
hageboeck
added
the
skip code analysis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running gtest-tree-ntuple-ntuple-type-name in address sanitizer, the check for the "const" qualifier ran out of bounds, because the cursor in TClassEdit.cxx:1793 was already at the end of the string, and "next" was one character after its end:
strcmp isn't designed for this case, so this commit adds length checks
before all "strcmp(base+offset, ...)" patterns.
I believe the test worked because the garbage that's read in memory is almost always
!= 'c'('o', 'n', ...), and so the comparison is (usually) guaranteed to fail -- until it doesn't.