Allow hash tables for TGeo volumes to rehash automatically#21327
Open
davidlange6 wants to merge 1 commit intoroot-project:masterfrom
Open
Allow hash tables for TGeo volumes to rehash automatically#21327davidlange6 wants to merge 1 commit intoroot-project:masterfrom
davidlange6 wants to merge 1 commit intoroot-project:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current TGeoVolume::AddVolume is a performance bottleneck in creation of large geometry models (eg, the idea detector geometry model for fcc studies). Allowing the hash tables to automatically rehash (as is already done for other hash tables) speeds up the entire xml processing and detector geometry creation(using dd4hep) by about 4x for this detector.
I believe only TGeoManager::AddVolume is used in my testing.
Checklist:
This PR fixes #