[ML] Randomize train/test cluster boundary assignment in RDataLoader#22196
Open
siliataider wants to merge 2 commits into
Open
[ML] Randomize train/test cluster boundary assignment in RDataLoader#22196siliataider wants to merge 2 commits into
siliataider wants to merge 2 commits into
Conversation
Test Results 20 files 20 suites 2d 23h 17m 56s ⏱️ Results for commit 87db451. ♻️ This comment has been updated with latest results. |
vepadulano
approved these changes
May 15, 2026
Member
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
Nice! See minor considerations from my side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Previously
RDataLoaderalways assigned the first fraction of each cluster to training and the last fraction to validation. This meant that across different runs, the train/val split was always identical regardless of the seed.This PR fixes the issue by using the shuffle seed to randomly decide, per cluster, whether training takes the prefix or suffix of that cluster.
This PR fixes #22194