Skip to content

[ntuple][ATLAS experiment] Make RNTupleDescriptor RIterators usable…#22285

Open
rybkine wants to merge 3 commits into
root-project:masterfrom
rybkine:master-ntuple-iterators
Open

[ntuple][ATLAS experiment] Make RNTupleDescriptor RIterators usable…#22285
rybkine wants to merge 3 commits into
root-project:masterfrom
rybkine:master-ntuple-iterators

Conversation

@rybkine
Copy link
Copy Markdown

@rybkine rybkine commented May 13, 2026

… with STL algorithms

tree/ntuple/inc/ROOT/RNTupleDescriptor.hxx: ensure that the following iterators RNTupleDescriptor::RFieldDescriptorIterable::RIterator, RNTupleDescriptor::RClusterDescriptorIterable::RIterator, RNTupleDescriptor::RColumnDescriptorIterable::RIterator, RNTupleDescriptor::RColumnRangeIterable::RIterator, RNTupleDescriptor::RClusterGroupDescriptorIterable::RIterator DefaultConstructible, RNTupleDescriptor::RExtraTypeInfoDescriptorIterable::RIterator, Experimental::RNTupleAttrSetDescriptorIterable::RIterator meet the requirements of Cpp17ForwardIterator or LegacyForwardIterator in the terminology of en.cppreference.com site

This Pull request:

Changes or fixes:

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

This PR fixes #22284

… with STL algorithms

tree/ntuple/inc/ROOT/RNTupleDescriptor.hxx: ensure that the following iterators
RNTupleDescriptor::RFieldDescriptorIterable::RIterator, RNTupleDescriptor::RClusterDescriptorIterable::RIterator, RNTupleDescriptor::RColumnDescriptorIterable::RIterator, RNTupleDescriptor::RColumnRangeIterable::RIterator, RNTupleDescriptor::RClusterGroupDescriptorIterable::RIterator DefaultConstructible, RNTupleDescriptor::RExtraTypeInfoDescriptorIterable::RIterator, Experimental::RNTupleAttrSetDescriptorIterable::RIterator
meet the requirements of Cpp17ForwardIterator or LegacyForwardIterator in the terminology of en.cppreference.com site
@rybkine rybkine requested a review from jblomer as a code owner May 13, 2026 10:55
@github-actions
Copy link
Copy Markdown

Test Results

    22 files      22 suites   3d 17h 8m 1s ⏱️
 3 849 tests  3 848 ✅ 0 💤  1 ❌
76 030 runs  76 010 ✅ 0 💤 20 ❌

For more details on these failures, see this check.

Results for commit ccfb7a0.

Grigori Rybkine added 2 commits May 14, 2026 21:37
…criptor `RIterator`s

tree/ntuple/inc/ROOT/RNTupleDescriptor.hxx: make the iterator default constructor explicitly-defaulted
…RNTupleFromTTreeTest class

tree/dataframe/test/dataframe_snapshot_ntuple.cxx: extend the field iterable lifetime while its iterator is in use by an algorithm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RNTupleDescriptor RIterators are not usable with STL algorithms

2 participants