Skip to content

[minicern] reduce code duplication to easen debugging#22291

Open
ferdymercury wants to merge 50 commits into
root-project:masterfrom
ferdymercury:microcern
Open

[minicern] reduce code duplication to easen debugging#22291
ferdymercury wants to merge 50 commits into
root-project:masterfrom
ferdymercury:microcern

Conversation

@ferdymercury
Copy link
Copy Markdown
Collaborator

@ferdymercury ferdymercury commented May 13, 2026

Non-functional change, it just reduces duplicities and more than 2500 lines of code

@ferdymercury ferdymercury force-pushed the microcern branch 3 times, most recently from e97d615 to b40efe5 Compare May 13, 2026 17:23
@ferdymercury ferdymercury marked this pull request as ready for review May 13, 2026 17:52
@ferdymercury ferdymercury requested a review from dpiparo as a code owner May 13, 2026 17:52
@ferdymercury ferdymercury requested a review from hageboeck May 13, 2026 17:53
@github-actions
Copy link
Copy Markdown

Test Results

    22 files      22 suites   3d 11h 0m 49s ⏱️
 3 849 tests  3 849 ✅ 0 💤 0 ❌
76 935 runs  76 935 ✅ 0 💤 0 ❌

Results for commit b3c9374.

@ferdymercury ferdymercury requested review from couet and guitargeek May 13, 2026 21:04
@ferdymercury ferdymercury mentioned this pull request May 14, 2026
Comment thread misc/minicern/src/fzc.inc
@@ -0,0 +1,3 @@
C=== fcz.inc ===================================================
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
C=== fcz.inc ===================================================
C=== fzc.inc ===================================================

@dpiparo dpiparo self-assigned this May 15, 2026
@dpiparo
Copy link
Copy Markdown
Member

dpiparo commented May 15, 2026

Thanks for this huge refactoring. I was wondering if the structure of the commits is to bekept or whether you imagined squashing (some of) them.

@ferdymercury
Copy link
Copy Markdown
Collaborator Author

Thanks! I think it's easier to review them one by one, but once it's approved you can squash them into a single one, or whatever N you consider useful, I don't mind :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants