Merged
Conversation
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
cottsay
requested changes
Apr 10, 2026
Comment on lines
-176
to
-178
| qt6-qtbase \ | ||
| qt6-qtbase-devel \ | ||
| qt6-qtbase-gui \ |
Member
There was a problem hiding this comment.
Aren't these needed for non-Python Qt6 packages like Rviz?
Contributor
Author
There was a problem hiding this comment.
if qt6 is not present in the system we should be able to compile RViz with qt5.
bindings should be fine with qt5 too.
Member
There was a problem hiding this comment.
Ah, sounds good then. I think we'll want these for RHEL 10 though:
$(if test ${EL_RELEASE/.*/} -gt 9; then echo qt6-qtbase qt6-qtbase-devel qt6-qtbase-gui; fi) \
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
sloretz
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Revert qt6 support on RHEL
Related with this comment ros-visualization/qt_gui_core#293 (comment)