Roll forward: "Detect when the kernel multiplexed hw counters."#2423
Open
tbosch wants to merge 1 commit intorr-debugger:masterfrom
Open
Roll forward: "Detect when the kernel multiplexed hw counters."#2423tbosch wants to merge 1 commit intorr-debugger:masterfrom
tbosch wants to merge 1 commit intorr-debugger:masterfrom
Conversation
Even though we now pin counters, tests show that multiplexing is still happening. NEW: Fixes the original commit to use tmp_attr properly for the case of `IN_TXCP`. This reverts commit 3677e44.
Contributor
Author
|
See discussion on #2421 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though we now pin counters, tests show that multiplexing
is still happening.
NEW: Fixes the original commit to use tmp_attr properly for the
case of
IN_TXCP.This reverts commit 3677e44.
Our use case:
A host is running linux perf now and then to get machine stats, in parallel to
rr.Without this detection, rr silently succeeds.