Skip to content

feat: stream skill installation output in task log#121

Merged
chenjiahan merged 1 commit intorstackjs:mainfrom
colinaaa:feat/skill-install-tasklog
Apr 9, 2026
Merged

feat: stream skill installation output in task log#121
chenjiahan merged 1 commit intorstackjs:mainfrom
colinaaa:feat/skill-install-tasklog

Conversation

@colinaaa
Copy link
Copy Markdown
Contributor

@colinaaa colinaaa commented Apr 8, 2026

Summary

  • replace the skill install spinner with @clack/prompts taskLog
  • stream tinyexec output into the skill install log and keep error messages scoped to the install command
  • update the skill install tests and test names to match the current task log behavior
Start Installing Failed
image image image

Test Plan

  • pnpm test -- test/skills.test.ts
  • pnpm test
  • pnpm lint

});

for await (const line of proc) {
installationTaskLog.message(line);
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to switch back to cross-spawn to use raw stream after bombshell-dev/clack#509 is merged.

Copy link
Copy Markdown
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chenjiahan chenjiahan merged commit 47d575d into rstackjs:main Apr 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants