Skip to content

chore: update Rspack to 2.0.0-beta.6#156

Open
chenjiahan wants to merge 4 commits intomainfrom
update_rspack_2.0.0-beta.6
Open

chore: update Rspack to 2.0.0-beta.6#156
chenjiahan wants to merge 4 commits intomainfrom
update_rspack_2.0.0-beta.6

Conversation

@chenjiahan
Copy link
Member

  • Upgrade @rspack/core and @rspack/cli from beta.5 to beta.6
  • Remove obsolete OpenOptions type and use DevServerOpenOptions from @rspack/core
  • Update related type definitions and imports

Copilot AI review requested due to automatic review settings March 11, 2026 09:23
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0232e9105c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repo to align with @rspack/core/@rspack/cli 2.0.0-beta.6, including adapting dev-server “open” option typing to upstream types.

Changes:

  • Bump @rspack/core / @rspack/cli from 2.0.0-beta.5 to 2.0.0-beta.6 (and update lockfile).
  • Remove the local OpenOptions type and switch to DevServerOpenOptions from @rspack/core.
  • Adjust related imports/type annotations in src/*.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/types.ts Switch normalized open option typing to DevServerOpenOptions and remove local OpenOptions definition.
src/server.ts Drop OpenOptions import and the now-obsolete cast on defaultOpenOptions.
src/config.ts Change ResolvedDevServer.open typing to use DevServerOpenOptions.
package.json Bump @rspack/core devDependency to 2.0.0-beta.6.
example/package.json Bump example @rspack/cli / @rspack/core to 2.0.0-beta.6.
pnpm-lock.yaml Lockfile updates for the beta.6 upgrade.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on maintaining compatibility and leveraging the latest improvements from the Rspack ecosystem by upgrading core dependencies to their newest beta version. It involves updating package manifests and adapting internal type definitions to reflect changes in the Rspack API, ensuring the project remains current and stable with the evolving build tool.

Highlights

  • Dependency Upgrade: Upgraded @rspack/core and @rspack/cli from 2.0.0-beta.5 to 2.0.0-beta.6 across the project and its examples.
  • Type Definition Refinement: Removed the obsolete OpenOptions type and replaced its usage with DevServerOpenOptions from @rspack/core to align with the updated Rspack API.
  • Lockfile Update: Updated the pnpm-lock.yaml to reflect the new Rspack dependency versions and their associated integrity hashes.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • example/package.json
    • Updated @rspack/cli and @rspack/core to version 2.0.0-beta.6.
  • package.json
    • Updated @rspack/core to version 2.0.0-beta.6.
  • pnpm-lock.yaml
    • Updated various @rspack package versions and their associated integrity hashes to 2.0.0-beta.6.
    • Removed entries for the 2.0.0-beta.5 versions of @rspack packages and their bindings.
  • src/config.ts
    • Imported DevServerOpenOptions from @rspack/core.
    • Updated the open property type in ResolvedDevServer from Open[] to DevServerOpenOptions[].
  • src/server.ts
    • Removed the import of the OpenOptions type.
    • Adjusted a type cast from OpenOptions to remove the explicit type assertion.
  • src/types.ts
    • Imported DevServerOpenOptions from @rspack/core.
    • Updated the options property type in NormalizedOpen from OpenOptions to DevServerOpenOptions.
    • Removed the OpenOptions type definition.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates @rspack/core and @rspack/cli to version 2.0.0-beta.6. As part of this upgrade, the local OpenOptions type definition has been removed and replaced with DevServerOpenOptions imported from @rspack/core. The changes across package.json files, the lockfile, and TypeScript source files are consistent and correctly implement the described update. The code is clean and I have no suggestions for improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants