Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0232e9105c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Updates the repo to align with @rspack/core/@rspack/cli 2.0.0-beta.6, including adapting dev-server “open” option typing to upstream types.
Changes:
- Bump
@rspack/core/@rspack/clifrom2.0.0-beta.5to2.0.0-beta.6(and update lockfile). - Remove the local
OpenOptionstype and switch toDevServerOpenOptionsfrom@rspack/core. - Adjust related imports/type annotations in
src/*.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/types.ts | Switch normalized open option typing to DevServerOpenOptions and remove local OpenOptions definition. |
| src/server.ts | Drop OpenOptions import and the now-obsolete cast on defaultOpenOptions. |
| src/config.ts | Change ResolvedDevServer.open typing to use DevServerOpenOptions. |
| package.json | Bump @rspack/core devDependency to 2.0.0-beta.6. |
| example/package.json | Bump example @rspack/cli / @rspack/core to 2.0.0-beta.6. |
| pnpm-lock.yaml | Lockfile updates for the beta.6 upgrade. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on maintaining compatibility and leveraging the latest improvements from the Rspack ecosystem by upgrading core dependencies to their newest beta version. It involves updating package manifests and adapting internal type definitions to reflect changes in the Rspack API, ensuring the project remains current and stable with the evolving build tool. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates @rspack/core and @rspack/cli to version 2.0.0-beta.6. As part of this upgrade, the local OpenOptions type definition has been removed and replaced with DevServerOpenOptions imported from @rspack/core. The changes across package.json files, the lockfile, and TypeScript source files are consistent and correctly implement the described update. The code is clean and I have no suggestions for improvement.
OpenOptionstype and useDevServerOpenOptionsfrom @rspack/core