hotfix: do not overide Rslib's underlying Rspack

[fi3ework]

human input:

1. revert all rspress stack back to linux, previously using mac to bypass native watcher bug. seems like it's been resolved.
2. do not override @rspack/core in the path of @rslib/core -> @rsbuild/core -> @rspack/core since Rspack 2.x is not compatible with latest @rslib/core. which will directly making build @rspack/core failed before any test ran.

[gemini-code-assist]

Summary of Changes

Hello @fi3ework, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a hotfix to prevent Rslib's underlying Rspack dependency from being unintentionally overridden, which could lead to compatibility issues. It achieves this by explicitly defining and enforcing specific compatible versions for critical packages within the dependency graph and by enhancing the package override mechanism to correctly handle development dependencies without interfering with complex dependency paths.

Highlights

• Compatibility Version Constants: Introduced new constants, RSLIB_RSBUILD_COMPAT_VERSION and RSLIB_RSPACK_COMPAT_VERSION, to explicitly define compatible versions for key packages within the Rslib ecosystem.
• Enforced Package Overrides: Implemented specific package overrides within the runInRepo function to ensure that @rslib/core, @rsbuild/core, @rspack/core, and @rspack/binding utilize the defined compatible versions, preventing unintended version conflicts.
• Refined Override Logic: Added a new utility function isValidManifestDepName and integrated it into applyPackageOverrides to filter development dependency overrides, ensuring that only valid package names (not dependency chains) are considered, thus preventing incorrect override applications.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• utils.ts
  • Defined RSLIB_RSBUILD_COMPAT_VERSION and RSLIB_RSPACK_COMPAT_VERSION constants.
  • Added explicit package overrides for @rslib/core>@rsbuild/core, @rsbuild/core@<version>>@rspack/core, and @rspack/core@<version>>@rspack/binding to ensure specific Rspack versions are used.
  • Implemented isValidManifestDepName function to validate package names for manifest dependencies.
  • Updated applyPackageOverrides to use isValidManifestDepName when filtering devOverrides to prevent overriding dependency chains.

Activity

• No specific activity (comments, reviews, etc.) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c6f27763a9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[gemini-code-assist]

Code Review

This pull request introduces a hotfix to correctly manage nested dependencies when testing with the rspack stack by adding specific pnpm overrides to pin versions of @rsbuild/core and @rspack/core. It also introduces the isValidManifestDepName function to filter out pnpm's special override syntax from devDependencies. However, the isValidManifestDepName function is implemented with a weak denylist, posing a medium-severity security risk due to improper sanitization of package names before writing to package.json. A more robust, regex-based validation is recommended for this function.