Ssr vtec misc#851
Open
ourairquality wants to merge 2 commits into
Open
Conversation
* Extend the single larger mapping function to accept a variable earth radius and single layer height. * Add a modified single-layer mapping function. * Add the Klobuchar mapping function, as used for GPS.
* rtcm3: guard against reading beyond the read length. * ionvtec: used the sun fixed longitude, correct legendre polynomials, calculate the mapping function for each layer height, guard against negative vtec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent SSR VTEC additions were of interest and noted a few possible issues, and this is a wip suggestion.
Bundling in another patch that helps - extending the mapping function to take the height so it can be calculated for each layer.
rtcm3: guard against reading beyond the read length.
ionvtec: used the sun fixed longitude. The model appears to be a sun fixed model that expects a shift to the time of day expected to have the hightest TEC, 2pm.
ionvtec: the legendre polynomials looks a little off at least for element 1,1 The articles I've seen give a constant of sqrt(3) for this but the optimised code appears to give that sqrtt(3/2), so suggesting a simpler less optimized loop, also break it down to match the common text descriptions.
ionvtec: calculate the mapping function for each layer height - spec suggests this.
ionvtec: guard against a negative vtec - spec suggests this, that it is a complex model that may have a poor fit in some areas.