Fix IE8 translated content not being removed.#128
Open
maxpeterson wants to merge 1 commit intorubenv:masterfrom
Open
Fix IE8 translated content not being removed.#128maxpeterson wants to merge 1 commit intorubenv:masterfrom
maxpeterson wants to merge 1 commit intorubenv:masterfrom
Conversation
In IE8 the old translated content is not removed by `$animate.leave`. Adding the `$compile` ensures the content is removed.
Contributor
Author
|
@rubenv any thoughts on this. It is a very easy fix however I am not sure why this works / is required in IE8. Hopefully you can reproduce it when you have time to look at IE8 issues. |
Owner
|
Do you have an example of how I can trigger this bug? The thing is: I don't see this behavior, IE8 correctly removes content for me. I'm hesitant to ship this patch as compiling is a heavy operation, so while it's just a single line of code, it has a very real impact on what happens on the page, for all users. It shouldn't be needed to have this line, so it might be a different bug. Could you provide me with a jsFiddle example? |
Owner
|
Removing from milestone since we cannot reproduce. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In IE8 the old translated content is not removed by
$animate.leave. The result is that the element ends up containing both the original content and the translated content.Adding the
$compileensures the content is removed.