Open
Conversation
Collaborator
|
Hello @bonsaiviking, Thanks for your patch. In order to merge the patch, each change must be validated with an unit test. Would you mind to update the patch? -- Simone |
Author
|
@weppos I've added the unit tests and rebased against master. |
|
I have forked this repository (after attempting and failing to contact author) here: https://github.com/mordocai/net-dns. If you wish to resubmit your pull request there I will review/merge it in. It will shortly be the gem net-dns2 on rubygems.org. |
|
I have merged your changes (minus tests, i'm writing new rspec tests) into my fork here: https://github.com/mordocai/net-dns/commit/81391af458a033d6a9bff4233c833b7364689cb4. It should be in the v0.8.3 release later this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.