Extract Entity DSL and refactor :with to keyword argument#2679
Open
ericproulx wants to merge 2 commits intomasterfrom
Open
Extract Entity DSL and refactor :with to keyword argument#2679ericproulx wants to merge 2 commits intomasterfrom
ericproulx wants to merge 2 commits intomasterfrom
Conversation
Danger ReportNo issues found. |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ericproulx
force-pushed
the
extract_entity_dsl_and_kwargs_with
branch
from
11fdb3d to
ac77bb3
Compare
- Move entity-related methods (present, entity_class_for_obj, entity_representation_for) from InsideRoute into a new Grape::DSL::Entity module - Convert options[:with] hash pattern to explicit `with:` keyword argument in rescue_from, represent Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ericproulx
force-pushed
the
extract_entity_dsl_and_kwargs_with
branch
from
ac77bb3 to
96e1589
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
present,entity_class_for_obj,entity_representation_for) fromGrape::DSL::InsideRouteinto a newGrape::DSL::Entitymoduleoptions[:with]hash pattern to explicitwith:keyword argument inerror_formatter,rescue_from,represent, andErrorFormatter::Base#presentTest plan
bundle exec rspecpasses (excluding pre-existing failure inspec/grape/exceptions/validation_spec.rb:15)rescue_from,represent,error_formatter, and entity presentation still work end-to-end🤖 Generated with Claude Code