Revert "Add a workaround for slow BigDecimal#to_f when it has large N_significant_digits"#522
Merged
tompng merged 1 commit intoruby:masterfrom Apr 8, 2026
Merged
Conversation
tompng
force-pushed
the
revert_to_f_workaround
branch
from
eb1a3c7 to
88851b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 3bf735f.
BigDecimal#to_sfor large n_significant_digits number became about 10 times fast.huge_n_significant_digit_number.to_fis still not fast. It takes O(N) time although we only need first 16-digit for BigMath use-case, butto_fis no longer a bottleneck of BigMath and its test execution time anymore.