Use ObjectSpace::WeakKeyMap for level_override#136
Open
nevans wants to merge 1 commit intoruby:masterfrom
Open
Use ObjectSpace::WeakKeyMap for level_override#136nevans wants to merge 1 commit intoruby:masterfrom
nevans wants to merge 1 commit intoruby:masterfrom
Conversation
This allows fiber keys to be GCed and removed from the map. Otherwise, fibers that call `#with_level` create a memory leak if they are killed without running their ensure blocks.
nevans
force-pushed
the
logger_override-weak_key_map
branch
from
4b5c49e to
4576128
Compare
This was referenced Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows fiber keys to be GCed and removed from the map. Otherwise, fibers that call
#with_levelcreate a memory leak if they are abandoned without running their ensure blocks.Please note that
Thread#killis not the only way for a Fiber to be abandoned without running its ensure block. It's as simple asto_enum(:method_that_calls_with_level).next.This is related to @byroot's comment here: #132 (comment)