🥅💄 Support (monochrome) highlights in parse error details #603
+69
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the backtrace_locations don't _explicitly_ include the class name, this still feelds inherently brittle. But it's very useful! It's a worthwhile tradeoff, IMO.
This runs sprintf in two passes: once to apply the escape sequences and again to interpolate variables. This requires `%%` for the second pass, which _can_ be confusing. Maybe this approach is too much for the very simple highlighting in this version? But, it seems to work okay for elaborate color schemes, too. IMO it's easier to read and maintain than a bunch of conditional string appending. And it's simpler than the other templating approaches that I considered.
nevans
force-pushed
the
response_parse_error-detailed_message-highlights
branch
from
f7f580c to
e5656a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This first version is monochrome: only bold and underline highlights are added. A follow-up PR adds color.