🐛 Config version_defaults should be attr_reader#631
Merged
nevans merged 1 commit intov0.5-stablefrom Mar 28, 2026
Merged
Conversation
nevans
added
bug
Although `version_defaults` is deeply frozen, it used `attr_accessor`!
nevans
force-pushed
the
backport/v0.5/594-fix-version_defaults-attr_accessor
branch
from
e855b17 to
0fb7a8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although
version_defaultsis deeply frozen, it usedattr_accessor!This PR backports #594 to
v0.5-stable. It fixes a bug that was introduced in #584 (which backported #544 to this branch).