Reject infix operators on command call on writes#3949
Merged
Conversation
Collaborator
|
This is casting too wide a net. This code used to be ok but now isn't: # steep-1.10.0/lib/steep/interface/function.rb
kp = keyword_params | other.keyword_params or return
^~ unexpected 'or', expecting end-of-input
^~ unexpected 'or', ignoring itI have a few more cases in https://gist.github.com/Earlopain/908f5744ae2c32bf4ab1d0a590b4e6c5 but I did not check them all. They all seem rather similar though ( Can you take a look? |
Collaborator
|
I reverted for now in #3960 with some added tests for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3106