Conversation
Earlopain
reviewed
Mar 6, 2026
src/prism.c
Outdated
| if (!PM_NODE_TYPE_P(value, PM_CALL_NODE)) return false; | ||
|
|
||
| const pm_call_node_t *call = (const pm_call_node_t *) value; | ||
| return pm_call_node_command_p(call) && (call->receiver == NULL || call->call_operator_loc.length > 0); |
Collaborator
There was a problem hiding this comment.
I feel like I also tried this but I guess not. Can you put it in a different PR?
Collaborator
Author
There was a problem hiding this comment.
Ahh whoops, yeah that was different work.
Introduce PM_TOKEN_KEYWORD_DO_BLOCK to distinguish do-blocks on command-style calls from regular `do` keywords. Add parse_command_do_block to attach these blocks to call nodes. Track in_endless_def_body to prevent do-block consumption inside endless method definitions, allowing blocks to correctly bubble up to outer contexts like `private def f = puts "Hello" do end`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce keyword_do_block to match parse.y behavior, as well as do a big audit of behavior to line up as closely as possible.