Add support for mise.toml#700
Merged
eregon merged 6 commits intoruby:masterfrom Feb 5, 2025
hobbypunk90:patch-1
Merged
Conversation
eregon
reviewed
Feb 4, 2025
Member
eregon
left a comment
eregon
left a comment
There was a problem hiding this comment.
Thank you for the PR, it looks good, just one small thing to address
| const rubyLine = toolVersions.split(/\r?\n/).filter(e => /^ruby\s/.test(e))[0] | ||
| rubyVersion = rubyLine.match(/^ruby\s+(.+)$/)[1] | ||
| console.log(`Using ${rubyVersion} as input from file .tool-versions`) | ||
| } else if (rubyVersion === 'mise.toml') { // Read from mise.toml |
Member
There was a problem hiding this comment.
https://mise.jdx.dev/configuration.html has 6 possible locations 😅
Hopefully mise.toml is the most common one, I don't really want to logic to search all those.
So yeah, let's look for just mise.toml for now.
Contributor
Author
There was a problem hiding this comment.
i see, you are right 😅 especially the conf.d would be crap 😁
eregon
reviewed
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.