Don't mutate a string literal in main code sample

[byroot]

I know this is still being debated, but as of the current version of Ruby, the first code sample does emit a deprecation warning (hidden by default but still).

I think it's would be better to not mutate a string literal.

[BurdetteLamar]

@byroot, I don't feel qualified to review.

[byroot]

@BurdetteLamar I ddin't make the request, it's automatic.

But @hsbt is in the reviewer, I think he can make that call.

[BurdetteLamar]

Okay, thanks.

[st0012]

I also prefer to not mutate string in the example.
(And if we still want string mutation, I feel String#sub! would better demonstrate it)

[st0012]

nit: I think this is the only place in the examples using single quotes. Let's use double quotes too for consistency and avoid confusion?

Suggested change

	say = say.sub('love', "*love*")
	say = say.sub("love", "*love*")

[jeremyevans]

It's a little uglier, but it's more important to be correct than pretty. The idiomatic approach would be to use String#+@, but that's cryptic and not a good choice for the front page of the website.

[hsbt]

I agree that this is not a good example, I overlooked this code example while working.