Conversation
… StoryIdea, WorkshopIdea, WorkshopVariation, EventRegistration is created
jmilljr24
reviewed
Jan 5, 2026
| # Set host to be used by links generated in mailer templates. | ||
| config.action_mailer.default_url_options = { host: "example.com" } | ||
| config.action_mailer.default_url_options = { | ||
| host: "example.com", |
Collaborator
There was a problem hiding this comment.
Suggested change
| host: "example.com", | |
| host: ENV.fetch("APP_HOST"), |
We have this set as an env so I think we can use it here.
jmilljr24
reviewed
Jan 5, 2026
|
|
||
| if @workshop_idea.save | ||
| NotificationServices::CreateNotification.call( | ||
| noticeable: @story_idea, |
Collaborator
There was a problem hiding this comment.
Suggested change
| noticeable: @story_idea, | |
| noticeable: @workshop_idea, |
jmilljr24
reviewed
Jan 5, 2026
| } | ||
|
|
||
| config.after_initialize do | ||
| if ENV["MANDRILL_USERNAME"].blank? || ENV["MANDRILL_APIKEY"].blank? |
Collaborator
There was a problem hiding this comment.
Suggested change
| if ENV["MANDRILL_USERNAME"].blank? || ENV["MANDRILL_APIKEY"].blank? | |
| if ENV["SMTP_USERNAME"].blank? || ENV["MANDRILL_APIKEY"].blank? |
Do we ever user APIKEY ?
If we do change this to SMTP_USERNAME can you also update the dummy value names in Dockerfile so the precompile doesn't fail on this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instructions on how to run actionmailer locally without a full-blown SMTP server #13
Expand Notification to store audit fields #213
Beef up Notification model to capture the actual body of the message sent #406
Email notifications on submission of workshop_idea, story_idea, workshop_variation, event registration #287
What is the goal of this PR and why is this important?
How did you approach the change?
Anything else to add?