Skip to content

Notifications followup #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maebeale merged 12 commits into from
Jan 6, 2026
Merged

Notifications followup #634

maebeale merged 12 commits into from
Jan 6, 2026

Conversation

@maebeale
Copy link
Collaborator

@maebeale maebeale commented Jan 6, 2026 •
edited
Loading

What is the goal of this PR and why is this important?

  • Fix prod env var name
  • Make notifications and notification previews work for all models w assets
  • Remove personal emails from codebase
  • Change hard-coded programs@awbw.org to always first look for ENV REPLY_TO_EMAIL var
  • Remove code in notification and contact_us that branched on windows_type, bc stakeholder no longer separates them
  • Change display of quote on notification email
  • Add guard clause to form_image_field bc it was blowing up on create for some reason (saying image didn't have signed_id, bc it wasn't saved yet)

How did you approach the change?

Anything else to add?

  • Made some small improvements to WorkshopVariation views found when testing notifications

maebeale added 12 commits January 6, 2026 10:26
@maebeale
Order workshop_variations by created_at desc
626b59d
@maebeale
Update mailer code to not have hard-coded emails
4c22fa4
@maebeale
Add has_many :assets to all models that have primary_asset and galler…
07cdb49 
…y_assets so they'll be accessible in bulk to generic views, incl notifications
@maebeale
Change display of quote on notification email
650eeaf
@maebeale
Fix report_notification to handle missing type
14061ec
@maebeale
Change name of form_image_field_insert
7d4aa9f
@maebeale
Change display of workshop_variations index to be buttons to associat…
b2c1bee 
…ed objects
@maebeale
Show all assets on workshop_variation show
32609b7
@maebeale
Correct env var fetched in prod for mandrill
b4ff6ed
@maebeale
Don't use notification last for report_notification preview
76e15a0
@maebeale
Change form_image_field to skip previews if action_name == 'create' (…
03c0265 
…it was causing an error)
@maebeale
Remove hard-coded emails and always try first to fetch REPLY_TO_EMAIL…
06ca599 
… from env rather than hard-coded programs@awbw.org
@maebeale maebeale force-pushed the notifications-followup branch from 84314e4 to 06ca599 Compare January 6, 2026 15:26
@maebeale maebeale merged commit 3420124 into main Jan 6, 2026
3 checks passed
@maebeale maebeale deleted the notifications-followup branch January 6, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove personal emails from codebase

2 participants

@maebeale