Facilitators can bookmark workshops#638
Merged
maebeale merged 1 commit intorubyforgood:mainfrom Jan 7, 2026
Merged
Conversation
Collaborator
|
@diti0-dot great job! No, I think what you have covers the functionality just fine. Though if you feel strongly there should be the option to navigate via profile, happy for you to add it! However maybe adding another PR to add more specs to this test so we're capturing all the places you can bookmark a workshop, might be good? (Places in addition to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
Add a test to ensure facilitators can successfully bookmark workshops
How did you approach the change?
Createdt the test that simulates a facilitator logging in, navigating to workshops, bookmarking one, and verifying it appears in their bookmarks.
Anything else to add?
Should I add a navigation via profile like: profile ->My bookmarks?