Race Condition Check: spec/system/devise/passwords/new_spec.rb#6780
Open
stefannibrasil wants to merge 3 commits intorubyforgood:mainfrom
Open
Race Condition Check: spec/system/devise/passwords/new_spec.rb#6780stefannibrasil wants to merge 3 commits intorubyforgood:mainfrom
stefannibrasil wants to merge 3 commits intorubyforgood:mainfrom
Conversation
When github's free CI servers are under heavy load, a race condition between the page loading and checking the database causes tests to flake. This is caused by a system test inputting data into a form then immediately checking the database without waiting for the form to finish submitting. For every database check in the system files, make sure it's preceded by a capybara matcher with automatic waiting or replace the database check with a check for something to appear on the page.
This reduces test setup time. I also find it easier to understand when the test checks that an attribute is present instead of not nil.
stefannibrasil
requested review from
FireLemons,
compwron and
elasticspoon
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #6320
What changed, and why?
When github's free CI servers are under heavy load, a race condition
between the page loading and checking the database causes tests to flake.
This is caused by a system test inputting data into a form then
immediately checking the database without waiting for the form to finish submitting.
For every database check in the system files, this ensures it's preceded
by a capybara matcher with automatic waiting or replace the database
check with a check for something to appear on the page.
I also took the opportunity to refactor some small things:
example.comto be RFC 2606 compliant