Open
Conversation
| it "can be REALLY destroyed" do | ||
| a_user.really_destroy! | ||
| expect(a_user.destroyed?).to eq(true) | ||
|
|
There was a problem hiding this comment.
Extra empty line detected at block body end.
Collaborator
|
Which images table do you mean? Which route do you mean (whats the url, the localhost development one is fine)? I'll double check it and fix it if I borked something :) |
Collaborator
Author
|
@jkeam I think I fixed the issue. Had to do some git magic. Not really sure what happened, but the schema includes your changes now. |
Collaborator
|
I think this looks good 👍 . If there are no objections from the team I'm ok with merging this in. Great job! |
Collaborator
|
Just adding in the issue that I created after the fact to track this functionality. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds soft delete functionality on the backend with the paranoia gem. Includes tests (which pass! yay!).
Will add delete option to admin dashboard in next PR.
@jkeam The images table that you created disappears when I run db:migrate. I don't know why.