Tailwinds conversions #425
Open
+6,759
−1,902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
We'll want to get the tag and file management interfaces back in shape. |
- Replace custom pagination with Pagy bootstrap helper and ensure search filter params persist across pages - Update search ordering to use published_at instead of created_at for topics - Fix password reset page link text expected by tests (Login) and restore test description text - Adjust Searcheable concern year/month scopes to handle blank params safely
…ect and ensure correct ordering for tests
- Ensure state filter respects enums in Searcheable#by_state - Force immediate form submission for month and state selects to avoid stale content in tests
We do not have a surver/privacy policy/terms of use and only registered users can log in, so I removed those links and the card that made it sound like anyone could sign up.
With the old design, we were filtering out archived topics by default.
Oli0li
force-pushed
the
tailwinds_conversions
branch
from
850fe0c to
a6811e4
Compare
Collaborator
|
I've resolved the conflicts/removed some unnecessary links, still need to fix:
|
This was causing the content of the table to be displayed by default on a green background, making it hard to read.
It wasn't clear to me what it meant when I saw it. Since it is not some kind of code to help idenfity a certain category of topic, I think it is best to remove it to avoid confusion and leave more space for the title.
Oli0li
force-pushed
the
tailwinds_conversions
branch
from
82f5572 to
5afd19b
Compare
Users can already see this info on the form or when clicking on "View Topic Details" at the bottom of the form.
Red is generally displayed for destructive actions, but here we were displaying "Edit" in red and "Archive" in orange. Since we are using orange on the Edit forms elsewhere, I've used orange for the Edit button, gray for Archive, and red for Delete. But orange is also often used to indicate a mildly dangerous action, so I wonder if it should be changed to something less alarming, like blue, purple or green. But editing a Topic can indeed be slightly dangerous if the user makes a mistake, so it could also be argued that orange is appropriate.
I also removed the "Danger Zone" as I thought it was a bit confusing that it showed warnings for a Delete feature that does not exist. If the stakeholders need this feature, they will let us know and we can add it at that point.
Admins can already see that information on the form itself or by clicking on the "View Provider Details" button below.
Collaborator
|
I've asked Claude to help convert a lot of the repetitive inline styles into Tailwind classes, but there are still many files to cover.
|
The password reset page was completely unstyled. I re-used the same style as we have for the "Send reset instructions" page.
I saw no difference visually or in functionality after removing this code.
The password visibility toggle was displayed far to the right of the screen instead of in the password input field because the parent div was not the password field, but also contained the label.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP