feat: add OSRS Bank Sync#12470
Open
kyleamielke wants to merge 4 commits into
Open
Conversation
Adds a manifest entry for kyleamielke/osrs-bank-sync v0.1.0 — a plugin that captures the bank contents on close and POSTs them as JSON to a user-configurable URL. See https://github.com/kyleamielke/osrs-bank-sync for full design + threading notes + security posture. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
New plugin |
kyleamielke
added a commit
to kyleamielke/osrs-bank-sync
that referenced
this pull request
Jun 7, 2026
The io.freefair.lombok Gradle plugin v8.14.2 isn't in Plugin Hub's gradle/verification-metadata.xml allowlist (only 5.3.0 is). The plugin is just a convenience wrapper around the explicit compileOnly + annotationProcessor declarations we already have in build.gradle, so dropping the `id 'io.freefair.lombok'` line is a no-op for compilation but unblocks Plugin Hub CI. WikiSync (our submission precedent) uses the same explicit-declaration pattern without the freefair plugin. Verified: ./gradlew build still passes all 27 tests. Fixes Plugin Hub CI failure on PR runelite/plugin-hub#12470. Co-authored-by: kyleamielke <3060686+kyleamielke@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Drops the io.freefair.lombok Gradle plugin which wasn't in Plugin Hub's gradle/verification-metadata.xml. Lombok itself is still wired via the explicit compileOnly + annotationProcessor declarations that were already there. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
kyleamielke
added a commit
to kyleamielke/osrs-bank-sync
that referenced
this pull request
Jun 7, 2026
…ub deprecated APIs) (#61) The widgets.WidgetInfo and widgets.InterfaceID APIs were terminally deprecated in favor of gameval.InterfaceID. Plugin Hub CI rejects plugins that still use the old APIs. Changes: - BankSyncButton.java: import gameval.InterfaceID; use BANKMAIN/Bankmain.TITLE/Bankmain.SEARCH - OsrsBankSyncPlugin.java: import gameval.InterfaceID; use BANKMAIN - DESIGN.md: revert the incorrect "spec drift" fix from PR #58 — gameval.InterfaceID.BANKMAIN was the correct API all along Verified: ./gradlew build still passes all 27 tests. Fixes Plugin Hub CI failure on PR runelite/plugin-hub#12470 (second failure after the build.gradle io.freefair.lombok fix). Co-authored-by: kyleamielke <3060686+kyleamielke@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Migrates plugin code from terminally-deprecated widgets.WidgetInfo and widgets.InterfaceID to gameval.InterfaceID, unblocking Plugin Hub CI's deprecated-API check. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
kyleamielke
added a commit
to kyleamielke/osrs-bank-sync
that referenced
this pull request
Jun 7, 2026
…(#62) Plugin Hub's packager requires the build= property to be set in runelite-plugin.properties. Their README example uses build=standard, which is the default mode for plugins that compile cleanly with the packager's bundled gradle setup. This is the third Plugin Hub CI gate found by PR runelite/plugin-hub#12470, following the io.freefair.lombok drop (#60) and the gameval.InterfaceID migration (#61). Verified: ./gradlew build still passes 27 tests (the properties file is consumed only by Plugin Hub's packager, not by our local build). Co-authored-by: kyleamielke <3060686+kyleamielke@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Adds the missing build= property required by Plugin Hub's packager. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Plugin Hub manifest
plugins/osrs-bank-syncfor OSRS Bank Sync.Pinned commit
29b473c9e87e6a38c20a6e0cfb98446676659e6fTrust model / data flow
This plugin follows the same trust model used by sync-oriented plugins such as WikiSync: users explicitly configure a destination endpoint, and data is sent only to that configured URL. To make that risk explicit, the manifest includes a warning line describing the exact payload (bank item IDs/quantities, display name, account hash, account type) and transport caveat when using non-HTTPS remote URLs.
For reviewer convenience, this PR pins release commit
29b473c9e87e6a38c20a6e0cfb98446676659e6f.