log-adviser: bump to 043bda1 (sidebar sync button)#12487
Closed
SFranciscoSouza wants to merge 1 commit into
Closed
log-adviser: bump to 043bda1 (sidebar sync button)#12487SFranciscoSouza wants to merge 1 commit into
SFranciscoSouza wants to merge 1 commit into
Conversation
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
Contributor
Author
|
Closing in favour of #12484. This was an experiment to see whether moving the collection-log Sync button from the in-game interface to the plugin sidebar (dropping the widget-creation APIs) would let the update auto-approve; it still routes to maintainer review, so there's no benefit over #12484. Please disregard this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the pinned commit for Log Adviser to the latest code.
2c47277->043bda1033665cdf765c24018fe2a61e8d88fca6What changed
The collection-log Sync control was moved off the in-game collection-log interface and onto the Log Adviser sidebar panel ("Sync now" button). The in-game button widget (
CollectionLogSyncButton) is removed entirely; the underlying full-sync logic is unchanged.This drops all in-game widget-creation API usage (
WidgetType,JavaScriptCallback,WidgetPositionMode,WidgetTextAlignment,SpriteID,FontID).Notes for review
buildcheck passes;./gradlew build(incl. tests) green locally.