Skip to content

log-adviser: bump to 043bda1 (sidebar sync button)#12487

Closed
SFranciscoSouza wants to merge 1 commit into
runelite:masterfrom
SFranciscoSouza:log-adviser-sidebar-sync
Closed

log-adviser: bump to 043bda1 (sidebar sync button)#12487
SFranciscoSouza wants to merge 1 commit into
runelite:masterfrom
SFranciscoSouza:log-adviser-sidebar-sync

Conversation

@SFranciscoSouza

Copy link
Copy Markdown
Contributor

Bumps the pinned commit for Log Adviser to the latest code.

What changed

The collection-log Sync control was moved off the in-game collection-log interface and onto the Log Adviser sidebar panel ("Sync now" button). The in-game button widget (CollectionLogSyncButton) is removed entirely; the underlying full-sync logic is unchanged.

This drops all in-game widget-creation API usage (WidgetType, JavaScriptCallback, WidgetPositionMode, WidgetTextAlignment, SpriteID, FontID).

Notes for review

  • No external/network behavior — the plugin makes no outbound HTTP calls.
  • No new third-party dependencies.
  • build check passes; ./gradlew build (incl. tests) green locally.

@runelite-github-app

Copy link
Copy Markdown

@runelite-github-app

Copy link
Copy Markdown

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@SFranciscoSouza

Copy link
Copy Markdown
Contributor Author

Closing in favour of #12484. This was an experiment to see whether moving the collection-log Sync button from the in-game interface to the plugin sidebar (dropping the widget-creation APIs) would let the update auto-approve; it still routes to maintainer review, so there's no benefit over #12484. Please disregard this one.

@SFranciscoSouza SFranciscoSouza deleted the log-adviser-sidebar-sync branch June 8, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant