fix: use threading for canary module exec#294
Merged
Conversation
KAJdev
changed the title
audryhsu
approved these changes
Mar 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the runtime module import timeout mechanism used by the project scanner to work reliably during flash run (and on Windows) by replacing the previous signal-based approach with a thread-based timeout.
Changes:
- Replace
SIGALRMtimeout handling with a daemon thread +join(timeout=...)for module import execution. - Update
_import_module_from_filedocstring to describe the new timeout strategy.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
KAJdev
deleted the
zeke/ae-2702-dev-server-docs-drop-lb-route-after-hot-reload
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where hot reloading wasnt working during
flash run. the method used (SIGALRM) does not work on Windows, nor when the thread isn't the main interpreter thread (e.g. during flash run).This just switches to using threading instead, which works on all platforms and in any current thread. its simpler to look at too.