Store HTTP Last-Modified as mtime in .dvc deps#8
Open
ryan-williams wants to merge 3 commits intomainfrom
Open
Conversation
Implemented in 052e047 ("Fix `dvx run` circular dependency error + add `git_deps` support"). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Pin `dvc-data` to runsascoded/dvc-data@`9b27dc6` which captures HTTP `Last-Modified` headers into `Meta.mtime` via `from_info()`. Add `_compat.py` to patch DVC at runtime: - Allow `mtime` in DVC's `.dvc` file schema validation - Extend `Meta.to_dict()` to serialize `mtime` for HTTP sources (distinguished from local fs mtime by absence of `inode`) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Meta.to_dict()to serialize HTTPLast-Modifiedasmtimein.dvcdep entriesinode is Noneheuristic to distinguish HTTP sources (no inode) from local files (always have inode)dvc-datafork with HTTP mtime extraction inMeta.from_info()+ ruff/CI fixesfix-run-external-depsspec tospecs/done/Test plan
dvx import-urlon an HTTP URL that returnsLast-Modifiedheader.dvcfile containsmtimefield in depsdvx updaterefreshesmtimedvc addstill works (no spuriousmtimein outs)hccs/pathwith real PDF imports🤖 Generated with Claude Code