[Clippy] Add clippy to CI, allow current violations at a module level#1280
Open
DanielEScherzer wants to merge 1 commit into
Open
[Clippy] Add clippy to CI, allow current violations at a module level#1280DanielEScherzer wants to merge 1 commit into
DanielEScherzer wants to merge 1 commit into
Conversation
DanielEScherzer
force-pushed
the
clippy-ci
branch
2 times, most recently
from
2b090f2 to
134e953
Compare
weihanglo
reviewed
Jun 15, 2026
| } | ||
|
|
||
| #[cfg(test)] | ||
| #[allow(clippy::needless_borrow)] |
Member
There was a problem hiding this comment.
Is it possible to add these allow to [lints.clippy] table?
Contributor
Author
There was a problem hiding this comment.
I wanted to make it clear where the existing violations were so that it would be clear what needs fixing, and so that we don't introduce more warnings in other files. If this is merged (or if you expect to merge this soon) I can start sending the PRs to fix the violations and remove the allowing
DanielEScherzer
force-pushed
the
clippy-ci
branch
2 times, most recently
from
644741f to
b2dd5cd
Compare
Add clippy to CI so that future changes do not increase the number of violations. The existing violations are allowlisted on a module level (i.e. at the top of files with inner attributes, or above the start of nested inline test modules with outer attributes). CI runs clippy on both Window and Linux because some lints may fire on one but not the other; see, e.g. rust-lang#1238. Existing violations will be addressed in subsequent pull requests.
DanielEScherzer
force-pushed
the
clippy-ci
branch
from
b2dd5cd to
5f690e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add clippy to CI so that future changes do not increase the number of violations. The existing violations are allowlisted on a module level (i.e. at the top of files with inner attributes, or above the start of nested inline test modules with outer attributes).
CI runs clippy on both Window and Linux because some lints may fire on one but not the other; see, e.g. #1238.
Existing violations will be addressed in subsequent pull requests.