wasi: add all _SC_* sysconf constants from wasi-libc#5023
Open
surban wants to merge 2 commits intorust-lang:mainfrom
Open
wasi: add all _SC_* sysconf constants from wasi-libc#5023surban wants to merge 2 commits intorust-lang:mainfrom
surban wants to merge 2 commits intorust-lang:mainfrom
Conversation
Add the complete set of _SC_* constants from wasi-libc's musl-based unistd.h.
There was a problem hiding this comment.
Pull request overview
This PR expands the WASI target’s exported sysconf name constants in src/wasi/mod.rs and updates the WASI semver symbol list accordingly, improving libc API completeness for WASI consumers.
Changes:
- Added a broad set of
_SC_*sysconfselector constants for the WASI target. - Updated
libc-test/semver/wasi.txtto include the newly exported WASI symbols.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/wasi/mod.rs |
Adds WASI _SC_* constants (sysconf name IDs) to the WASI libc surface. |
libc-test/semver/wasi.txt |
Records the new WASI symbols in the semver baseline list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
@rustbot retry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the complete set of
_SC_*sysconf constants for WASI targets from wasi-libc's musl-basedunistd.h.Applies to both
wasm32-wasip1andwasm32-wasip1-threads.Sources
unistd.h: https://github.com/WebAssembly/wasi-libc/blob/2fc32bc81b9f07f8d9525edea59bfbaf760c06d6/libc-top-half/musl/include/unistd.h#L396Checklist
*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI
@rustbot label +stable-nominated