Fix constants accidentally removed for Linux uClibc targets#5141
Open
operutka wants to merge 1 commit into
Open
Fix constants accidentally removed for Linux uClibc targets#5141operutka wants to merge 1 commit into
operutka wants to merge 1 commit into
Conversation
Contributor
Author
|
I've got an update related to the local tests. I've generated a new toolchain using Buildroot with up to date kernel headers but I'm still unable to build the Given that, I believe the tests never worked on the Linux uClibc target in the first place and, in fact, the I think fixing the tests for uClibc is a whole different job that's well outside of scope of this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes constants that were, probably accidentally, removed by commit 2fe1d91 for uClibc in all operating systems. However, based on the commit message, the commit was supposed to fix things for L4Re, not break things for other operating systems.
So this PR limits the uClibc exclusions introduced in 2fe1d91 to apply only if the target OS is L4Re. This also fixes #5140.
Sources
I believe no links to sources are necessary here. The affected constants were previously available for all linux-like operating systems and environments. This PR simply reverts things to the previous state for all operating systems except L4Re.
Checklist
libc-test/semverhave been updated*LASTor*MAXare included (see #3131)cd libc-test && cargo test --target mytarget); especially relevant for platforms that may not be checked in CINotes
There was nothing to update in
libc-test/semver. The constants are already present inlinux.txt.I'm unable to run the tests locally though. After building custom
rustcandrust-stdforarmv7-unknown-linux-uclibceabihf, I'm able to initiate the build oflibc-testbut it fails because the following header files are missing in my case:linux/can/j1939.hlinux/mount.hlinux/openat2.hI guess they require a more up to date Linux headers then I currently have in my toolchain. When I comment out the header files, I get a ton of missing symbol errors. I'll try to re-run the test with a more recent toolchain.
@rustbot label +stable-nominated