Skip to content

fix: Support filesystems that don't send Create events #21844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChayimFriedman2 merged 2 commits into from
Apr 1, 2026
Merged

fix: Support filesystems that don't send Create events #21844

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38052f1
internal: Split absolute path collection from reading files
Wilfred Mar 19, 2026
19e0346
fix: Support filesystems that don't send Create events
Wilfred Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 31 additions & 4 deletions crates/vfs-notify/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ use std::{
};

use crossbeam_channel::{Receiver, Sender, select, unbounded};
use notify::{Config, EventKind, RecommendedWatcher, RecursiveMode, Watcher};
use notify::{Config, EventKind, RecommendedWatcher, RecursiveMode, Watcher, event::AccessKind};
use paths::{AbsPath, AbsPathBuf, Utf8PathBuf};
use rayon::iter::{IndexedParallelIterator as _, IntoParallelIterator as _, ParallelIterator};
use rustc_hash::FxHashSet;
Expand Down Expand Up @@ -63,6 +63,7 @@ struct NotifyActor {
sender: loader::Sender,
watched_file_entries: FxHashSet<AbsPathBuf>,
watched_dir_entries: Vec<loader::Directories>,
seen_paths: FxHashSet<AbsPathBuf>,
// Drop order is significant.
watcher: Option<(RecommendedWatcher, Receiver<NotifyEvent>)>,
}
Expand All @@ -79,6 +80,7 @@ impl NotifyActor {
sender,
watched_dir_entries: Vec::new(),
watched_file_entries: FxHashSet::default(),
seen_paths: FxHashSet::default(),
watcher: None,
}
}
Expand Down Expand Up @@ -120,6 +122,7 @@ impl NotifyActor {
let n_total = config.load.len();
self.watched_dir_entries.clear();
self.watched_file_entries.clear();
self.seen_paths.clear();

self.send(loader::Message::Progress {
n_total,
Expand Down Expand Up @@ -195,10 +198,12 @@ impl NotifyActor {
},
Event::NotifyEvent(event) => {
if let Some(event) = log_notify_error(event)
&& let EventKind::Create(_) | EventKind::Modify(_) | EventKind::Remove(_) =
event.kind
&& let EventKind::Create(_)
| EventKind::Modify(_)
| EventKind::Remove(_)
| EventKind::Access(AccessKind::Open(_)) = event.kind
{
let files = event
let abs_paths: Vec<AbsPathBuf> = event
.paths
.into_iter()
.filter_map(|path| {
Expand All @@ -207,6 +212,28 @@ impl NotifyActor {
.expect("path is absolute"),
)
})
.collect();

let mut saw_new_file = false;
for abs_path in &abs_paths {
if self.seen_paths.insert(abs_path.clone()) {
saw_new_file = true;
}
}

// Only consider access events for files that we haven't seen
// before.
//
// This is important on FUSE filesystems, where we may not get a
// Create event. In other cases we're about to access the file, so
// we don't want an infinite loop where processing an Access event
// creates another Access event.
if matches!(event.kind, EventKind::Access(_)) && !saw_new_file {
continue;
}

let files = abs_paths
.into_iter()
.filter_map(|path| -> Option<(AbsPathBuf, Option<Vec<u8>>)> {
// Ignore events for files/directories that we're not watching.
if !(self.watched_file_entries.contains(&path)
Expand Down