Add clause to etiquette about using English#1060
Merged
Merged
Conversation
rustbot
added
the
S-waiting-on-review
apiraino
force-pushed
the
add-clause-to-use-english
branch
from
b222052 to
615284f
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
jieyouxu
reviewed
Jun 3, 2026
| - If you want to fix an issue but have doubts about the design, you're welcome to join our [Zulip][rust-zulip] server and ask for tips | ||
| - Please respect the reviewers' time: allow some days between reviews, only ask for reviews when your code compiles and tests pass, or give an explanation for why you are asking for a review at that stage (you can keep them in draft state until they're ready for review) | ||
| - Try to keep comments concise, don't worry about a perfect written communication. Strive for clarity and being to the point | ||
| - We prefer using the English language to follow conventions of existing commits. Again, don't worry about writing a perfect prose |
Member
There was a problem hiding this comment.
Suggestion: I might say sth like
- Please use English to communicate (including e.g. commit messages). The grammar or prose does not need to be perfect at all!
- This is because contributors come from all over the world, so a common language is needed to communicate. The lingua franca happens to be English1.
I kinda want to balance between being to-the-point (concise) and giving some context on why. I think this should also point to the machine translation note if the Forge policy is accepted 2.
Footnotes
Contributor
Author
There was a problem hiding this comment.
in commit 3faa350 I'm trying a shorter version of your suggestion, wdyt?
(condensing text is hard)
jieyouxu
approved these changes
Jun 4, 2026
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussed on Zulip.
Open to reword that sentence (I am not English mother-tongue 😉 )
r? @jieyouxu
Rendered