Skip to content

run-make-support: add wrapper for fs operations#125736

Merged
bors merged 1 commit intorust-lang:masterfrom
Oneirical:run-make-file-management
Jun 11, 2024
Merged

run-make-support: add wrapper for fs operations#125736
bors merged 1 commit intorust-lang:masterfrom
Oneirical:run-make-file-management

Conversation

@Oneirical
Copy link
Contributor

@Oneirical Oneirical commented May 29, 2024

Suggested by #125728.

The point of this wrapper is to stop silent fails caused by forgetting to unwrap fs functions. However, functions like fs::read which return something and get stored in a variable should cause a failure on their own if they are not unwrapped (as the Result will be stored in the variable, and something will be done on that Result that should have been done to its contents). Is it still pertinent to wrap fs::read_to_string, fs::metadata and so on?

Closes: #125728

try-job: x86_64-msvc
try-job: i686-mingw

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

run-make-support: add helpers for fs operations

7 participants