[Perf Experiment] Change FxHash to GxHash#127040
Closed
blyxyas wants to merge 2 commits intorust-lang:masterfrom
Closed
[Perf Experiment] Change FxHash to GxHash#127040blyxyas wants to merge 2 commits intorust-lang:masterfrom
blyxyas wants to merge 2 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've done some experiments comparing hashing libraries that can be found in crates.io, and it while FxHash is faster than the default hasher, Gxhash is still about 10 times faster than fxhash.
This is just with the default implementation, the library permits customization using CPU-specific optimizations. But we can ask the maintainers for that if we were to verify that the optimization is big enough.