Do not skip linker configuration for check builds#130135
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 9, 2024
Merged
Do not skip linker configuration for check builds#130135bors merged 1 commit intorust-lang:masterfrom
check builds#130135bors merged 1 commit intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This essentially reverts a part of #128871, to fix #130108. This is mostly a hotfix until we can figure out a better way to both avoid rebuilds and avoid configuring the linker for
x check.Skipping linker for check builds was causing unexpected rebuilds.
Fixes: #130108