Stabilize unsigned and float variants of num_midpoint feature#131784
Merged
bors merged 1 commit intorust-lang:masterfrom Dec 2, 2024
Merged
Stabilize unsigned and float variants of num_midpoint feature#131784bors merged 1 commit intorust-lang:masterfrom
num_midpoint feature#131784bors merged 1 commit intorust-lang:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes that we stabilize the unsigned variants of the
num_midpointfeature as well as the floats variants, since they are not subject to any unresolved questions, which is equivalent to doing(a + b) / 2(and(a + b) >> 1) in a sufficiently large number.The stabilized API surface would be:
The signed variants
u{8,16,32,64,128,size}would remain gated, until a decision is made about the rounding mode, in other words that the unresolved questions are resolved.cc @rust-lang/libs-api
cc @scottmcm
r? libs-api