Skip to content

import simd_ intrinsics#137551

Merged
bors merged 4 commits intorust-lang:masterfrom
folkertdev:import-simd-intrinsics
Mar 1, 2025
Merged

import simd_ intrinsics#137551
bors merged 4 commits intorust-lang:masterfrom
folkertdev:import-simd-intrinsics

Conversation

@folkertdev
Copy link
Contributor

@folkertdev folkertdev commented Feb 24, 2025

In most cases, we can import the simd intrinsics rather than redeclare them. Apparently, most of these tests were written before std::intrinsics::simd existed.

There are a couple of exceptions where we can't yet import:

  • the intrinsics are not declared as const fn in the standard library, causing issues in the const-eval tests
  • the simd_shuffle_generic function is not exposed from std::intrinsics
  • the simd_fpow and simd_fpowi functions are not exposed from std::intrinsics (removed in remove simd_fpow and simd_fpowi #137595)
  • some tests use no_core, and therefore cannot use std::intrinsics

r? @RalfJung

cc @workingjubilee do you have context on why some intrinsics are not exposed?

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants