Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In most cases, we can import the simd intrinsics rather than redeclare them. Apparently, most of these tests were written before
std::intrinsics::simdexisted.There are a couple of exceptions where we can't yet import:
const fnin the standard library, causing issues in theconst-evaltestssimd_shuffle_genericfunction is not exposed fromstd::intrinsicssimd_fpowandsimd_fpowifunctions are not exposed fromstd::intrinsics(removed in removesimd_fpowandsimd_fpowi#137595)no_core, and therefore cannot usestd::intrinsicsr? @RalfJung
cc @workingjubilee do you have context on why some intrinsics are not exposed?