Do not compute optimized MIR if code does not type-check.#147092
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 29, 2025
Merged
Do not compute optimized MIR if code does not type-check.#147092bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #128612, we compute optimized MIR when
-Zvalidate-miris present.This is done as part of required analyses, even if type-checking fails. This causes ICEs, as most of the mir-opt pipeline expects well-formed code.
Fixes #129095
Fixes #134174
Fixes #134654
Fixes #135570
Fixes #136381
Fixes #137468
Fixes #144491
Fixes #147011
This does not fix issue #137190, as it ICEs without
-Zvalidate-mir.r? @compiler-errors