Skip to content

Check ConstArgHasType goals even when not wfchecking #150322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
BoxyUwU wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Check ConstArgHasType goals even when not wfchecking #150322

BoxyUwU wants to merge 1 commit into from
+541 −73

Conversation

@BoxyUwU
Copy link
Member

@BoxyUwU BoxyUwU commented Dec 23, 2025 •
edited by rustbot
Loading

Fixes #149774

r? types

@rustbot
Copy link
Collaborator

rustbot commented Dec 23, 2025

changes to the core type system

cc @compiler-errors, @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 23, 2025
BoxyUwU
BoxyUwU commented Dec 23, 2025
View reviewed changes
compiler/rustc_hir_analysis/src/check/wfcheck.rs
enter_wf_checking_ctxt_inner(tcx, body_def_id, !tcx.features().trivial_bounds(), f)
}

pub(super) fn enter_wf_checking_ctxt_without_checking_global_bounds<'tcx, F>(
Copy link
Member Author

@BoxyUwU BoxyUwU Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems suboptimal to me that we implicitly check things about the where clauses of an item just from creating a wfcx. ideally this would happen as part of actually checking the where clauses or something?

@BoxyUwU
Copy link
Member Author

BoxyUwU commented Dec 23, 2025

@bors try

rust-bors bot added a commit that referenced this pull request Dec 23, 2025
@rust-bors
Auto merge of #150322 - BoxyUwU:check_const_types_without_wfck, r=<try>
d15b493 
Check `ConstArgHasType` goals even when not wfchecking
@rust-bors

This comment has been minimized.

Sign in to view
@BoxyUwU
Copy link
Member Author

BoxyUwU commented Dec 23, 2025

needs a crater run + fcp

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link
Contributor

rust-bors bot commented Dec 23, 2025

💔 Test for d15b493 failed: CI. Failed jobs:

@BoxyUwU BoxyUwU force-pushed the check_const_types_without_wfck branch from ef323a1 to 1b22adb Compare December 24, 2025 00:48
@BoxyUwU
Copy link
Member Author

BoxyUwU commented Dec 24, 2025

crazy, completely flipped one of the like two conditions in this PR by accident

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Dec 24, 2025
@rust-bors
Auto merge of #150322 - BoxyUwU:check_const_types_without_wfck, r=<try>
e983148 
Check `ConstArgHasType` goals even when not wfchecking
@rust-bors
Copy link
Contributor

rust-bors bot commented Dec 24, 2025

☀️ Try build successful (CI)
Build commit: e983148 (e983148bd5f0f0db270bfb72149f5e892e68b67f, parent: 2ca7bcd03b87b52f7055a59b817443b0ac4a530d)

BoxyUwU
BoxyUwU commented Dec 24, 2025
View reviewed changes
compiler/rustc_trait_selection/src/traits/wf.rs
debug!(?self.out);
}

#[instrument(level = "debug", skip(self))]
Copy link
Member Author

@BoxyUwU BoxyUwU Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont yeet this

@BoxyUwU
Copy link
Member Author

BoxyUwU commented Dec 24, 2025

@craterbot check

@craterbot
Copy link
Collaborator

craterbot commented Dec 24, 2025

👌 Experiment pr-150322 created and queued.
🤖 Automatically detected try build e983148
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 24, 2025
@craterbot
Copy link
Collaborator

craterbot commented Jan 1, 2026

🚧 Experiment pr-150322 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

craterbot commented Jan 2, 2026

🎉 Experiment pr-150322 is completed!
📊 8 regressed and 5 fixed (766471 total)
📊 2036 spurious results on the retry-regressed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

  1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-150322/retry-regressed-list.txt ↩

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jan 2, 2026
@BoxyUwU
Copy link
Member Author

BoxyUwU commented Jan 2, 2026

@craterbot check crates=https://crater-reports.s3.amazonaws.com/pr-150322/retry-regressed-list.txt

@craterbot
Copy link
Collaborator

craterbot commented Jan 2, 2026

👌 Experiment pr-150322-1 created and queued.
🤖 Automatically detected try build e983148
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 2, 2026
@craterbot craterbot added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Jan 2, 2026
@BoxyUwU
Copy link
Member Author

BoxyUwU commented Jan 2, 2026

damn people are actually relying on this :(

@lcnr
Copy link
Contributor

lcnr commented Jan 5, 2026

"relying on this" 😅 people actually have incorrect unused type aliases in their code xd

@BoxyUwU
Copy link
Member Author

BoxyUwU commented Jan 5, 2026

technically they can be used because you can do sth like type Foo<const N: u8> = [(); N]; fn foo<const N: usize>() -> Foo<N> {} and I think it'll work

@craterbot
Copy link
Collaborator

craterbot commented Jan 6, 2026

🚧 Experiment pr-150322-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

craterbot commented Jan 6, 2026

🎉 Experiment pr-150322-1 is completed!
📊 5 regressed and 0 fixed (1937 total)
📊 150 spurious results on the retry-regressed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

  1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-150322-1/retry-regressed-list.txt ↩

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lcnr lcnr

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Not using anon consts for uses of const parameters caused us to accept more code for free type aliases

5 participants

@BoxyUwU @rustbot @rust-log-analyzer @craterbot @lcnr