stdarch subtree update #150357

ZuseZ4 · 2025-12-24T18:56:55Z

Subtree update of stdarch to rust-lang/stdarch@6111906.

Created using https://github.com/rust-lang/josh-sync.

My first josh sync, it lgtm, but let me know if I missed something.
I'm especially looking forward to the amd GPU module, which we want to use for the offload project.

This fixes build issues associated with failing LLVM const param assertions

The intrinsics test was flagging differences in aarch64_be between rust in debug and clang in O2. It was found that rust was correct in debug, but incorrect in release, and in both cases were being compared against clang in O2 which was also incorrect. The vdot intrinsics were fixed and are now correct in rust for both release and debug. However the vcmla ones could not be as the issue lies with LLVM. Both the vdot and vcmla intrinsics were added to the skiplist as clang is still incorrect for both. LLVM issue: llvm/llvm-project#166190

…rinsics-debug Fixes issue with arm intrinsics not compiling in dev profile

Use generic SIMD intrinsics for cvtepi intrinsics

Correct the docs for WASM relaxed_simd's `relaxed_min`/`relaxed_max` operations

… list

Format `f16` values correctly in intrinsic-test

Make `cpuid` safe and update docs

s390x: use `simd_shuffle!` macro

use `wrapping_add` for `_kadd` intrinsics

instead of len(intrinsic) output streams

…-test-updates `intrinsic-test`: Coalescing all intrinsic tests into a single run of the test-file binaries

bors · 2025-12-26T04:22:41Z

📌 Commit 62b5c88 has been approved by sayantn

It is now in the queue for this repository.

bors · 2025-12-26T04:24:00Z

⌛ Testing commit 62b5c88 with merge 0301e3f...

stdarch subtree update Subtree update of `stdarch` to rust-lang/stdarch@6111906. Created using https://github.com/rust-lang/josh-sync. r? `@sayantn` My first josh sync, it lgtm, but let me know if I missed something. I'm especially looking forward to the amd GPU module, which we want to use for the offload project.

bors · 2025-12-26T05:14:15Z

💔 Test failed - checks-actions

rustbot · 2025-12-26T07:47:00Z

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

ZuseZ4 · 2025-12-26T07:47:50Z

@bors2 try jobs=dist-various-2

stdarch subtree update try-job: dist-various-2

rust-bors · 2025-12-26T08:36:59Z

☀️ Try build successful (CI)
Build commit: d16d763 (d16d76398507db7765d67ac7ec447a2e3dc24320, parent: fabece9e9491d0a3c3655dba488881968b7c5f7a)

ZuseZ4 · 2025-12-26T09:39:56Z

Ok, it looks like I found the missing unsafe cpuid calls now (no other changes), let's try again:
@bors r=sayantan

bors · 2025-12-26T09:39:59Z

📌 Commit 6f06d38 has been approved by sayantan

It is now in the queue for this repository.

bors · 2025-12-26T10:44:34Z

⌛ Testing commit 6f06d38 with merge 2e854a9...

bors · 2025-12-26T13:51:18Z

☀️ Test successful - checks-actions
Approved by: sayantan
Pushing 2e854a9 to main...

github-actions · 2025-12-26T13:54:53Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4c383cd (parent) -> 2e854a9 (this PR)

Test differences

Show 44 test diffs

44 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 2e854a9344154564259de51385e9ec9506c0f3b7 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

aarch64-apple: 11756.3s -> 10011.1s (-14.8%)
dist-apple-various: 3740.9s -> 4211.9s (+12.6%)
dist-aarch64-msvc: 5336.2s -> 5953.4s (+11.6%)
x86_64-mingw-1: 9163.8s -> 10148.4s (+10.7%)
aarch64-gnu: 7180.4s -> 7829.8s (+9.0%)
dist-x86_64-msvc-alt: 8857.3s -> 9626.7s (+8.7%)
pr-check-1: 1531.8s -> 1663.9s (+8.6%)
x86_64-gnu: 7534.4s -> 8129.0s (+7.9%)
dist-x86_64-llvm-mingw: 7137.3s -> 6632.5s (-7.1%)
dist-various-2: 2223.5s -> 2081.3s (-6.4%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

ytmimi · 2025-12-26T14:37:30Z

src/tools/rustfmt/tests/source/cfg_if/detect/os/x86.rs

For future reference rustfmt formatting tests shouldn't really need to be updated

Oh sorry @ytmimi, I hope I didn't cause too much extra work by that.
I had missed that the last CI failure here didn't include the rustfmt tests, I'll be more careful with cleanups in my next sync.

Overall it's not a big deal. I just wanted to point out that we don't need to make any changes for existing formatting test. Hopefully it saves a little time for you in the future.

rust-timer · 2025-12-26T14:39:32Z

Finished benchmarking commit (2e854a9): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	3
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -2.5%, secondary -2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.0%	[1.0%, 1.0%]	1
Regressions ❌ (secondary)	2.0%	[1.8%, 2.1%]	3
Improvements ✅ (primary)	-3.6%	[-7.0%, -0.8%]	3
Improvements ✅ (secondary)	-4.5%	[-5.1%, -4.1%]	6
All ❌✅ (primary)	-2.5%	[-7.0%, 1.0%]	4

Cycles

Results (secondary 2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.1%	[2.1%, 6.5%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.0%	[-2.0%, -2.0%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 483.337s -> 482.393s (-0.20%)
Artifact size: 392.36 MiB -> 390.46 MiB (-0.48%)

CrooseGit and others added 30 commits November 24, 2025 15:12

Fixes generator, neon intrinics now build in debug

d7860a5

This fixes build issues associated with failing LLVM const param assertions

Correct the docs for WASM relaxed_simd's min/max

b3f67c7

Provides work-around for vreinterpret inline fail

73ad94a

Merge pull request rust-lang#1964 from CrooseGit/dev/reucru01/arm-int…

3bbbddf

…rinsics-debug Fixes issue with arm intrinsics not compiling in dev profile

s390x: use simd_shuffle! macro

daa2cd3

Refactor max/min intrinsics using a helper function

4c49a7a

Use generic SIMD intrinsics for AVX512BW cvtepi

98a9545

Merge pull request rust-lang#1966 from sayantn/saturation

989aff2

Use generic SIMD intrinsics for cvtepi intrinsics

Merge pull request rust-lang#1963 from valadaptive/relaxed-minmax-docs

f7808ac

Correct the docs for WASM relaxed_simd's `relaxed_min`/`relaxed_max` operations

systematically exclude svml, mmx and mpx rather than having an ad-hoc…

00ee70d

… list

Format f16 values normally, rather than use the bit patterns

0c0de07

correct behavior of some intrinsics

8b35ef7

fix intrinsic-test to use core_arch::arch rather than std::arch

ae78a30

Make cpuid safe and update docs

3e8185f

Merge pull request rust-lang#1968 from sayantn/intrinsic-test

ac05d0d

Format `f16` values correctly in intrinsic-test

Merge pull request rust-lang#1935 from sayantn/safe-cpuid

46efc1b

Make `cpuid` safe and update docs

Merge pull request rust-lang#1965 from folkertdev/s390x-shuffle

21f714b

s390x: use `simd_shuffle!` macro

use wrapping_add for _kadd intrinsics

9f1724d

Merge pull request rust-lang#1969 from sayantn/fix-kadd

e282dc1

use `wrapping_add` for `_kadd` intrinsics

feat: configure test-files to run all intrinsics in the same process

f0f0b8b

feat: modified the compare function to check one huge output stream

344acad

instead of len(intrinsic) output streams

chore: formatting checks

a472b5d

feat: increase TEST_SAMPLE_INTRINSICS_PERCENTAGE of x86_64 to 30%

09a67df

fix: update the comparison algorithm for cleaner comparisons

99fbd39

feat: add equality checks to reduce computation spent on equal outputs

998aff3

feat: extract the delimiter to a const value for uniformity

7215e07

feat: reduce the intrinsics coverage for x86_64 intrinsics

060b4d3

chore: logging to trace the time taken by binaries to complete a run

d5c2590

Merge pull request rust-lang#1952 from madhav-madhusoodanan/intrinsic…

eb49e65

…-test-updates `intrinsic-test`: Coalescing all intrinsic tests into a single run of the test-file binaries

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 26, 2025

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 26, 2025

cpuid is safe since the stdarch sync, so remove unsafe from usages

6f06d38

ZuseZ4 force-pushed the zusez4-stdarch-push branch from 62b5c88 to 6f06d38 Compare December 26, 2025 07:46

rustbot added the T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue. label Dec 26, 2025

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Dec 26, 2025

Auto merge of #150357 - ZuseZ4:zusez4-stdarch-push, r=<try>

d16d763

stdarch subtree update try-job: dist-various-2

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 26, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 26, 2025

bors merged commit 2e854a9 into rust-lang:main Dec 26, 2025
13 checks passed

rustbot added this to the 1.94.0 milestone Dec 26, 2025

ZuseZ4 deleted the zusez4-stdarch-push branch December 26, 2025 14:08

ytmimi reviewed Dec 26, 2025

View reviewed changes

Uh oh!

stdarch subtree update #150357

stdarch subtree update #150357

Uh oh!

Conversation

ZuseZ4 commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Dec 26, 2025

Uh oh!

bors commented Dec 26, 2025

Uh oh!

This comment has been minimized.

bors commented Dec 26, 2025

Uh oh!

rustbot commented Dec 26, 2025

Uh oh!

ZuseZ4 commented Dec 26, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Dec 26, 2025

Uh oh!

ZuseZ4 commented Dec 26, 2025

Uh oh!

bors commented Dec 26, 2025

Uh oh!

bors commented Dec 26, 2025

Uh oh!

bors commented Dec 26, 2025

Uh oh!

Uh oh!

github-actions bot commented Dec 26, 2025

Test differences

Job duration changes

Uh oh!

ytmimi Dec 26, 2025

Choose a reason for hiding this comment

Uh oh!

ZuseZ4 Dec 26, 2025

Choose a reason for hiding this comment

Uh oh!

ytmimi Dec 26, 2025

Choose a reason for hiding this comment

Uh oh!

rust-timer commented Dec 26, 2025

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

ZuseZ4 commented Dec 24, 2025 •

edited

Loading