Skip to content

Conversation

@fee1-dead
Copy link
Member

@fee1-dead fee1-dead commented Dec 24, 2025

r? @oli-obk on #148434, cc @ytmimi for https://github.com/rust-lang/rust/pull/148434/changes#r2637972310

format_constness_right outputs " const" whereas format_constness outputs "const "

Not making this change to rust-lang/rustfmt since I'm not sure if that repo has these changes yet.

@rustbot
Copy link
Collaborator

rustbot commented Dec 24, 2025

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue. labels Dec 24, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 24, 2025

oli-obk is not on the review rotation at the moment.
They may take a while to respond.

@ytmimi
Copy link
Contributor

ytmimi commented Dec 24, 2025

@fee1-dead can we add a test case just to make sure there aren't issues moving forward?

@oli-obk
Copy link
Contributor

oli-obk commented Dec 25, 2025

r=me with test

@fee1-dead
Copy link
Member Author

@bors r=oli-obk rollup

@bors
Copy link
Collaborator

bors commented Dec 27, 2025

📌 Commit cf8d0c8 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2025
bors added a commit that referenced this pull request Dec 27, 2025
Rollup of 3 pull requests

Successful merges:

 - #148533 (Split LLVM intrinsic abi handling from the rest of the abi handling)
 - #150358 (fix rustfmt on `const impl Ty {}`)
 - #150434 (Add test for never type fallback in try blocks with `Into<!>`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 15b364e into rust-lang:main Dec 28, 2025
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Dec 28, 2025
rust-timer added a commit that referenced this pull request Dec 28, 2025
Rollup merge of #150358 - fee1-dead-contrib:push-utvysrrzsvvm, r=oli-obk

fix rustfmt on `const impl Ty {}`

r? `@oli-obk` on #148434, cc `@ytmimi` for https://github.com/rust-lang/rust/pull/148434/changes#r2637972310

format_constness_right outputs `" const"` whereas format_constness outputs `"const "`

Not making this change to rust-lang/rustfmt since I'm not sure if that repo has these changes yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants