Skip to content

Conversation

@estebank
Copy link
Contributor

No description provided.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 25, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 25, 2025

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@estebank
Copy link
Contributor Author

Looked into rewording this while prototyping #150233, and is an improvement regardless of whether that lands or not.

@nnethercote
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 1, 2026

📌 Commit 40be1f8 has been approved by nnethercote

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 1, 2026
bors added a commit that referenced this pull request Jan 1, 2026
…uwer

Rollup of 4 pull requests

Successful merges:

 - #150382 (Tweak wording of diff marker diagnostic)
 - #150431 (test and document that `proc_macro::Ident` is NFC-normalized)
 - #150504 (Add regression test for issue #99173)
 - #150568 (Update triagebot config for `compiler-errors`, `tests/{run-make,run-make-cargo}` and `fallback` adhoc_group)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 21d3df6 into rust-lang:main Jan 2, 2026
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 2, 2026
rust-timer added a commit that referenced this pull request Jan 2, 2026
Rollup merge of #150382 - estebank:git-markers-wording, r=nnethercote

Tweak wording of diff marker diagnostic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants