Skip to content

Conversation

@reddevilmidzy
Copy link
Member

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 26, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 26, 2025

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Kivooeo
Copy link
Member

Kivooeo commented Dec 26, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 26, 2025

📌 Commit d81ff85 has been approved by Kivooeo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 26, 2025
@Kivooeo Kivooeo assigned Kivooeo and unassigned nnethercote Dec 26, 2025
@bors
Copy link
Collaborator

bors commented Dec 26, 2025

⌛ Testing commit d81ff85 with merge 8da80d3...

@bors
Copy link
Collaborator

bors commented Dec 26, 2025

☀️ Test successful - checks-actions
Approved by: Kivooeo
Pushing 8da80d3 to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 26, 2025
@bors bors merged commit 8da80d3 into rust-lang:main Dec 26, 2025
12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Dec 26, 2025
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 2e854a9 (parent) -> 8da80d3 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 8da80d36a3b8fe4c0cc737b1e9494ce33a091f01 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-apple: 7591.9s -> 6421.4s (-15.4%)
  2. dist-x86_64-apple: 7556.9s -> 6418.6s (-15.1%)
  3. dist-aarch64-llvm-mingw: 5742.1s -> 6393.0s (+11.3%)
  4. x86_64-gnu-llvm-20-1: 4410.4s -> 3959.7s (-10.2%)
  5. dist-apple-various: 4211.9s -> 3796.5s (-9.9%)
  6. x86_64-gnu-llvm-21-2: 4960.6s -> 5434.3s (+9.5%)
  7. arm-android: 5821.1s -> 5366.3s (-7.8%)
  8. aarch64-msvc-2: 5892.0s -> 6304.1s (+7.0%)
  9. aarch64-gnu: 7829.8s -> 7285.6s (-7.0%)
  10. aarch64-gnu-llvm-20-1: 3514.4s -> 3270.7s (-6.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@reddevilmidzy reddevilmidzy deleted the hir-analysis branch December 26, 2025 17:09
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8da80d3): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.0% [0.0%, 0.1%] 4
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 5.6%, secondary 3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
5.6% [5.6%, 5.6%] 1
Regressions ❌
(secondary)
4.4% [2.3%, 5.6%] 7
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.9% [-2.1%, -1.6%] 2
All ❌✅ (primary) 5.6% [5.6%, 5.6%] 1

Cycles

Results (secondary -3.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.0% [2.0%, 2.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.9% [-6.2%, -2.9%] 6
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 482.393s -> 483.256s (0.18%)
Artifact size: 390.46 MiB -> 392.46 MiB (0.51%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants