Rollup of 22 pull requests by JonathanBrouwer · Pull Request #154227 · rust-lang/rust

JonathanBrouwer · 2026-03-22T21:24:17Z

Successful merges:

Add APIs for dealing with titlecase #122668 (Add APIs for dealing with titlecase)
privacy: Fix type privacy holes in RPITITs #152543 (privacy: Fix type privacy holes in RPITITs)
Optimize BTreeMap::append() using CursorMut #153107 (Optimize BTreeMap::append() using CursorMut)
Packages as namespaces part 1 #153312 (Packages as namespaces part 1)
Remove a flaky got_timeout assert from two channel tests #153534 (Remove a flaky got_timeout assert from two channel tests)
Fix environ on FreeBSD with cdylib targets that use -Wl,--no-undefined . #153718 (Fix environ on FreeBSD with cdylib targets that use -Wl,--no-undefined .)
Rename target.abi to target.cfg_abi and enum-ify llvm_abiname #153857 (Rename target.abi to target.cfg_abi and enum-ify llvm_abiname)
Lifted intersperse and intersperse_with Fused transformation and updated documentation + tests #153880 (Lifted intersperse and intersperse_with Fused transformation and updated documentation + tests)
remove usages of to-be-deprecated numeric constants #153931 (remove usages of to-be-deprecated numeric constants)
Unknown -> Unsupported compression algorithm #150630 (Unknown -> Unsupported compression algorithm)
Move freeze_* methods to OpenOptionsExt2 #153491 (Move freeze_* methods to OpenOptionsExt2)
Simplify find_attr! for HirId usage #153582 (Simplify find_attr! for HirId usage)
std: move sys::pal::os to sys::paths #153623 (std: move sys::pal::os to sys::paths)
docs(fs): Clarify That File::lock Coordinates Across Processes #153647 (docs(fs): Clarify That File::lock Coordinates Across Processes)
Skip stack_start_aligned for immediate-abort #153936 (Skip stack_start_aligned for immediate-abort)
implement BinaryHeap::as_mut_slice #154011 (implement BinaryHeap::as_mut_slice)
ui/lto: move and rename two tests from issues/ #154167 (ui/lto: move and rename two tests from issues/)
allow incomplete_features in most UI tests #154174 (allow incomplete_features in most UI tests)
Add new alias for Guillaume Gomez email address #154175 (Add new alias for Guillaume Gomez email address)
diagnostics: avoid ICE for undeclared generic parameter in impl #154182 (diagnostics: avoid ICE for undeclared generic parameter in impl)
Update the tracking issue for #[diagnostic::on_move] #154188 (Update the tracking issue for #[diagnostic::on_move])
Use enums to clarify DepNodeColorMap color marking #154201 (Use enums to clarify DepNodeColorMap color marking )

In CI, the receiver thread can be descheduled for a surprisingly long time, so there's no guarantee that a timeout actually occurs.

Instead of relying on the linker to find the 'environ' symbol, use dlsym. Fixes rust-lang#153451 Sponsored by: ConnectWise

Add a HasAttrs<'tcx, Tcx> trait to rustc_hir that allows find_attr! to accept DefId, LocalDefId, OwnerId, and HirId directly, instead of requiring callers to manually fetch the attribute slice first. The trait is defined in rustc_hir with a generic Tcx parameter to avoid a dependency cycle (rustc_hir cannot depend on rustc_middle). The four concrete impls for TyCtxt are in rustc_middle.

…d documentation + tests

This improves startup performance by 16%, shown by an optimized hello-world program. glibc's `pthread_getattr_np` performs expensive syscalls when reading `/proc/self/maps`. That is all wasted with `panic = immediate-abort` active because `init()` immediately discards the return value from `install_main_guard()`. A similar improvement can be seen in environments that don't have `/proc`. This change is safe because the immediately succeeding comment says that we rely on Linux's "own stack-guard mechanism".

Avoid an ICE for: struct A; impl A<B> {} The compiler no longer panics and can proceed to emit existing diagnostics. Adds `tests/ui/missing/undeclared-generic-parameter.rs`. Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>

Now that the tracking issue has been opened, point to it.

- `char::is_cased` - `char::is_titlecase` - `char::case` - `char::to_titlecase`

…s/ui/lto/

When a function's documentation has to explain the meaning of nested results and options, then it is often a good candidate for using a custom result enum instead. This commit also renames `DepNodeColorMap::try_mark` to `try_set_color`, to make it more distinct from the similarly-named `DepGraph::try_mark_green`. The difference is that `try_mark_green` is a higher-level operation that tries to determine whether a node _can_ be marked green, whereas `try_set_color` is a lower-level operation that actually records a color for the node.

This method is only used to initialize the always-red node, which can be done with `try_set_color` instead.

…riginate from

Both zstd and zlib are *known* compression algorithms, they just may not be supported by the backend. We shouldn't mislead users into e.g. thinking they made a typo.

JonathanBrouwer · 2026-03-22T21:24:30Z

@bors r+ rollup=never p=5

rust-bors · 2026-03-22T21:24:39Z

📌 Commit 905b306 has been approved by JonathanBrouwer

It is now in the queue for this repository.

JonathanBrouwer · 2026-03-22T21:24:46Z

Made of two rollups that already passed try jobs
#154219
#154222

JonathanBrouwer · 2026-03-22T22:47:36Z

@bors try jobs=x86_64-gnu-aux

Rollup of 22 pull requests try-job: x86_64-gnu-aux

…uwer Rollup of 22 pull requests Successful merges: - #122668 (Add APIs for dealing with titlecase) - #152543 (privacy: Fix type privacy holes in RPITITs) - #153107 (Optimize BTreeMap::append() using CursorMut) - #153312 (Packages as namespaces part 1) - #153534 (Remove a flaky `got_timeout` assert from two channel tests) - #153718 (Fix environ on FreeBSD with cdylib targets that use -Wl,--no-undefined .) - #153857 (Rename `target.abi` to `target.cfg_abi` and enum-ify llvm_abiname) - #153880 (Lifted intersperse and intersperse_with Fused transformation and updated documentation + tests) - #153931 (remove usages of to-be-deprecated numeric constants) - #150630 (Unknown -> Unsupported compression algorithm) - #153491 (Move `freeze_*` methods to `OpenOptionsExt2`) - #153582 (Simplify find_attr! for HirId usage) - #153623 (std: move `sys::pal::os` to `sys::paths`) - #153647 (docs(fs): Clarify That File::lock Coordinates Across Processes) - #153936 (Skip stack_start_aligned for immediate-abort) - #154011 (implement `BinaryHeap::as_mut_slice`) - #154167 (ui/lto: move and rename two tests from issues/) - #154174 (allow `incomplete_features` in most UI tests) - #154175 (Add new alias for Guillaume Gomez email address) - #154182 (diagnostics: avoid ICE for undeclared generic parameter in impl) - #154188 (Update the tracking issue for #[diagnostic::on_move]) - #154201 (Use enums to clarify `DepNodeColorMap` color marking )

rust-bors · 2026-03-23T04:12:56Z

💔 Test for 14b8819 failed: CI. Failed job:

auto - dist-x86_64-msvc (web logs, enhanced plaintext logs)

rust-bors · 2026-03-23T04:39:17Z

☀️ Try build successful (CI)
Build commit: 94aeafa (94aeafa034f01d546fe4f777d0440f0326b8237b, parent: 562dee4820c458d823175268e41601d4c060588a)

JonathanBrouwer · 2026-03-23T06:00:58Z

@bors retry

rust-bors · 2026-03-23T07:44:05Z

⌛ Testing commit 905b306 with merge d0d72c8...

Workflow: https://github.com/rust-lang/rust/actions/runs/23426643600

…uwer Rollup of 22 pull requests Successful merges: - #122668 (Add APIs for dealing with titlecase) - #152543 (privacy: Fix type privacy holes in RPITITs) - #153107 (Optimize BTreeMap::append() using CursorMut) - #153312 (Packages as namespaces part 1) - #153534 (Remove a flaky `got_timeout` assert from two channel tests) - #153718 (Fix environ on FreeBSD with cdylib targets that use -Wl,--no-undefined .) - #153857 (Rename `target.abi` to `target.cfg_abi` and enum-ify llvm_abiname) - #153880 (Lifted intersperse and intersperse_with Fused transformation and updated documentation + tests) - #153931 (remove usages of to-be-deprecated numeric constants) - #150630 (Unknown -> Unsupported compression algorithm) - #153491 (Move `freeze_*` methods to `OpenOptionsExt2`) - #153582 (Simplify find_attr! for HirId usage) - #153623 (std: move `sys::pal::os` to `sys::paths`) - #153647 (docs(fs): Clarify That File::lock Coordinates Across Processes) - #153936 (Skip stack_start_aligned for immediate-abort) - #154011 (implement `BinaryHeap::as_mut_slice`) - #154167 (ui/lto: move and rename two tests from issues/) - #154174 (allow `incomplete_features` in most UI tests) - #154175 (Add new alias for Guillaume Gomez email address) - #154182 (diagnostics: avoid ICE for undeclared generic parameter in impl) - #154188 (Update the tracking issue for #[diagnostic::on_move]) - #154201 (Use enums to clarify `DepNodeColorMap` color marking )

JonathanBrouwer · 2026-03-23T10:58:14Z

x86_64-gnu-aux seems frozen AGAIN............
I'll give it 30 more minutes to maybe finish

rust-bors · 2026-03-23T11:16:11Z

PR #122668, which is a member of this rollup, was unapproved.

This rollup was thus unapproved.

Auto build was cancelled due to unapproval. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/23426643600

JonathanBrouwer · 2026-03-23T11:16:32Z

The issue was this PR
#122668

petrochenkov and others added 30 commits February 12, 2026 18:20

privacy: Fix type privacy holes when it doesn't cause too much breakage

ef8c95c

Remove a flaky got_timeout assert from two channel tests

7cb6912

In CI, the receiver thread can be descheduled for a surprisingly long time, so there's no guarantee that a timeout actually occurs.

Fix environ on FreeBSD with cdylib targets that use -Wl,--no-undefined .

44d6cd2

Instead of relying on the linker to find the 'environ' symbol, use dlsym. Fixes rust-lang#153451 Sponsored by: ConnectWise

std: move sys::pal::os to sys::paths (rename/delete only)

d2e3ab6

std: move leftover Windows error test

f4a95d3

std: move sys::pal::os to sys::paths

be5f070

docs(fs): Clarify that File::lock coordinates across processes

0e0babc

Move freeze_* methods to OpenOptionsExt2

fb65707

Do not emit separator as before elements

425df0d

Lifted intersperse and intersperse_with Fused restrictions and update…

800d9ea

…d documentation + tests

Extend ASCII fast paths of char methods beyond ASCII

4eb9e66

remove usages of to-be-deprecated numeric constants

a893257

implement BinaryHeap::as_mut_slice

cab72ae

resolve namespaced crates with open modules

e844c24

Add new alias for Guillaume Gomez email address

9a4b38c

Point to the tracking issue for #[diagnostic::on_move]

e0aed9c

Now that the tracking issue has been opened, point to it.

Add APIs for dealing with titlecase

8d07261

- `char::is_cased` - `char::is_titlecase` - `char::case` - `char::to_titlecase`

Move and rename LTO-specific test files from tests/ui/issues/ to test…

9b7dff9

…s/ui/lto/

allow incomplete_features in most UI tests

9b0be78

Use BTreeMap::merge underneath the hood to deduplicate code

e2a870f

Remove DepNodeColorMap::insert_red

1fec51c

This method is only used to initialize the always-red node, which can be done with `try_set_color` instead.

target specs: rename abi to cfg_abi

40ebcc0

enum-ify llvm_abiname

6b14876

ensure Other variants are only used by JSON targets

4a0b264

Add comment at the top in two test files referencing the issue they o…

dd2b208

…riginate from

Unknown -> Unsupported compression algorithm

6458ca5

Both zstd and zlib are *known* compression algorithms, they just may not be supported by the backend. We shouldn't mislead users into e.g. thinking they made a typo.

rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue. labels Mar 22, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 22, 2026

This comment has been minimized.

Sign in to view

rust-bors bot pushed a commit that referenced this pull request Mar 22, 2026

Auto merge of #154227 - JonathanBrouwer:rollup-Y3AkxdT, r=<try>

94aeafa

Rollup of 22 pull requests try-job: x86_64-gnu-aux

This comment has been minimized.

Sign in to view

rust-bors bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 23, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 23, 2026

rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 23, 2026

rust-bors bot mentioned this pull request Mar 23, 2026

Add APIs for dealing with titlecase #122668

Open

JonathanBrouwer closed this Mar 23, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 23, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 22 pull requests#154227

Rollup of 22 pull requests#154227
JonathanBrouwer wants to merge 52 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-Y3AkxdT

JonathanBrouwer commented Mar 22, 2026

Uh oh!

JonathanBrouwer commented Mar 22, 2026

Uh oh!

rust-bors bot commented Mar 22, 2026

Uh oh!

JonathanBrouwer commented Mar 22, 2026

Uh oh!

JonathanBrouwer commented Mar 22, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Mar 23, 2026

Uh oh!

rust-bors bot commented Mar 23, 2026

Uh oh!

JonathanBrouwer commented Mar 23, 2026

Uh oh!

rust-bors bot commented Mar 23, 2026 •

edited

Loading

Uh oh!

JonathanBrouwer commented Mar 23, 2026

Uh oh!

rust-bors bot commented Mar 23, 2026

Uh oh!

JonathanBrouwer commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

JonathanBrouwer commented Mar 22, 2026

Uh oh!

JonathanBrouwer commented Mar 22, 2026

Uh oh!

rust-bors bot commented Mar 22, 2026

Uh oh!

JonathanBrouwer commented Mar 22, 2026

Uh oh!

JonathanBrouwer commented Mar 22, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Mar 23, 2026

Uh oh!

rust-bors bot commented Mar 23, 2026

Uh oh!

JonathanBrouwer commented Mar 23, 2026

Uh oh!

rust-bors bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Mar 23, 2026

Uh oh!

rust-bors bot commented Mar 23, 2026

Uh oh!

JonathanBrouwer commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

rust-bors bot commented Mar 23, 2026 •

edited

Loading