Skip to content

Remove misleading 'rvalue' terminology from transmute docs#154784

Closed
Herrtian wants to merge 1 commit intorust-lang:mainfrom
Herrtian:fix-transmute-docs-rvalue-153350
Closed

Remove misleading 'rvalue' terminology from transmute docs#154784
Herrtian wants to merge 1 commit intorust-lang:mainfrom
Herrtian:fix-transmute-docs-rvalue-153350

Conversation

@Herrtian
Copy link
Copy Markdown

@Herrtian Herrtian commented Apr 3, 2026

Summary

Fixes #153350

The transmute documentation example contained the comment:

// This now has three mutable references pointing at the same
// memory. `slice`, the rvalue ret.0, and the rvalue ret.1.

The term "rvalue" is not used elsewhere in standard library documentation and is confusing to readers. Additionally, there is no variable named ret in the code — the function returns an anonymous tuple.

Changed to:

// This now has three mutable references pointing at the same
// memory: `slice`, and the two returned mutable slices.

Replace "the rvalue ret.0, and the rvalue ret.1" with
"the two returned mutable slices" in the `transmute` documentation
example comment, as the term "rvalue" is not used elsewhere in
standard library documentation and can be confusing.

Fixes rust-lang#153350
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 3, 2026

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 3, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 3, 2026

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, jhpratt, scottmcm

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 3, 2026

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@jieyouxu
Copy link
Copy Markdown
Member

jieyouxu commented Apr 4, 2026

Hi, you've opened 10 PRs in very quick succession, and looking at the PR descriptions and some of the tests, I have some doubts regarding if the contributions are adaqutely self-reviewed. Recently, we have seen waves of automated contributions that are not adequately self-reviewed, which is why we are being more cautious.

In my capacity as a venue moderator, I am requesting that you respond to reviewer questions to

I am hereby placing a temporary embargo on creation of new PRs from you before the PRs mentioned above are responded to, and the reviewers develop more confidence that you are self-reviewing and understand your contributions. The temporary embargo will be lifted if the reviewers have sufficient confidence in your contributions.

Before the temporary embargo is lifted, any further PRs from your account will be closed. If new PRs continue to be raised from your account before so, further moderation action may be applied.

I am closing and locking this PR before the review discussions in the PRs linked above are settled and the temporary embargo lifted. If the temporary embargo is lifted, I will unlock and reopen this PR.

@jieyouxu jieyouxu closed this Apr 4, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 4, 2026
@rust-lang rust-lang locked and limited conversation to collaborators Apr 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs mention rvalue

4 participants